Update to React Character Map v0.3.0 and pass translatable text #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jeffpaul
added
type:bug
dinhtungdu
approved these changes
Mar 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This update will resolve #49 because React Character Map v.0.3.0 focuses the search input when the component is open.
It also resolves #51 by passing translated text to override the defaults in React Character Map.
See https://github.com/Dayjo/react-character-map/releases/tag/v0.3.0
Alternate Designs
Benefits
Possible Drawbacks
Verification Process
Search input will be focusable
Checklist:
Applicable Issues
Changelog Entry