Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH action summary for Cypress report #314

Merged
merged 11 commits into from
May 8, 2023
Merged

GH action summary for Cypress report #314

merged 11 commits into from
May 8, 2023

Conversation

jayedul
Copy link
Contributor

@jayedul jayedul commented May 2, 2023

Description of the Change

GH action summary added Cypress test report

Closes #298

Changelog Entry

Added - GH action summary added Cypress test report

Credits

Props @jayedul

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jayedul jayedul self-assigned this May 2, 2023
@jayedul jayedul marked this pull request as ready for review May 8, 2023 09:55
@jayedul jayedul requested review from jeffpaul and a team as code owners May 8, 2023 09:55
@jeffpaul jeffpaul added this to the 2.0.0 milestone May 8, 2023
@jeffpaul jeffpaul requested review from a team and peterwilsoncc and removed request for a team and jeffpaul May 8, 2023 14:36
@peterwilsoncc peterwilsoncc force-pushed the update/298 branch 2 times, most recently from 53f4f2f to 065f658 Compare May 8, 2023 23:18
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, as noted I pushed a change to ensure the summary always displays.

I pushed a commit with failing tests to ensure it works as expected, this has since been force pushed out of the history.

You can see the failing action run at https://github.com/10up/safe-redirect-manager/actions/runs/4920476448

.github/workflows/cypress.yml Show resolved Hide resolved
@peterwilsoncc peterwilsoncc merged commit 5818a6c into develop May 8, 2023
@peterwilsoncc peterwilsoncc deleted the update/298 branch May 8, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a GH Actions summary
3 participants