Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #1

Open
danielhuppmann opened this issue Apr 9, 2024 · 2 comments
Open

Review #1

danielhuppmann opened this issue Apr 9, 2024 · 2 comments

Comments

@danielhuppmann
Copy link
Collaborator

Please review, @Corny01

@Corny01
Copy link

Corny01 commented Apr 22, 2024

Description of repository

The repository contains a python code calculating the area of an rectangle and the volume of a cuboid by the given parameters of height, width (and higth). The part of the code which is commeted out (propably because of the instead failing pytest) asks for input of these parameters.
The repository contains two workflows to run a pytest for the first implemented function and a ruff test, a ReadMe and a licence file.

Tests

  • License exists
  • Create a fork and start a pull-request
  • Pytests fails as expected
  • Ruff linter fails not as expected even though two not-ruff-conform changes have been implemented

@Corny01
Copy link

Corny01 commented Apr 22, 2024

Submission of second homework assignment, @danielhuppmann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants