Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate method for line highlighting #42

Closed
zachleat opened this issue Dec 23, 2020 · 2 comments
Closed

Alternate method for line highlighting #42

zachleat opened this issue Dec 23, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@zachleat
Copy link
Member

Thought this was really interesting and didn’t require modification of the source to wrap/add divs, it’s a separate element:
image

As seen on https://rollup-plugin-vue.vuejs.org/examples.html

@zachleat zachleat added the enhancement New feature or request label Dec 23, 2020
@siimpragi
Copy link

Hi! It sure is an interesting way to achieve line highlighting. So I looked into it. It seems the wrapping <div>-s were dropped in favor of <mark>, <del>, and <ins> in #7. Since those tags are all nice and semantic, I wonder if there really are any reasons to go forward with this?

@zachleat
Copy link
Member Author

Closing as stale. I think the now-bundled diff- plugin is the better way forward here #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants