Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and removed lines get no special styling #64

Closed
siimpragi opened this issue Dec 10, 2021 · 1 comment
Closed

Added and removed lines get no special styling #64

siimpragi opened this issue Dec 10, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@siimpragi
Copy link

I ran the demo with a fenced code block that had some lines added and removed.

```js/4-5/2-3
let multilineString = `
  this is the first line
  this line is removed
  this line is also removed
  this line is added
  this line is also added
  this is the last line
`;
```

Those lines didn't seem to differentiate from "normal" lines. Here's a GIF:

hl-lines

The generated markup is fine. It's just that test.css hides the browser's default styles for <ins>, and <del>.

Could the stylesheet perhaps be changed so that we give appropriate background-color-s to .highlight-line-* similarly to how eleventy-base-blog does it?

If OK, would you be open to a PR?

@zachleat zachleat added this to the 4.1.0 milestone Jun 28, 2022
@zachleat
Copy link
Member

zachleat commented Jun 28, 2022

Good idea! (I made these changes to test.css! thank you)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants