Skip to content

Commit

Permalink
Add the requested vectors of trust to ServiceProviderRequest (#9991)
Browse files Browse the repository at this point in the history
* Add the requested vectors of trust to `ServiceProviderRequest`

We are working on implementing a feature for partners to request identity proofing and authentication features using vectors of trust. This will involve sending param describing the vector of trust in the original SAML or OIDC request. Within the context of OIDC this param is named `vtr`.

This commit adds a `vtr` property to `ServiceProviderRequest`. This property is unused and unset in the persisted service provider request. This will allow us to write to it in the future and initialize `ServiceProviderRequest`s with the value without resulting in an `ArgumentError` (thus avoiding a dreaded 50/50 state bug)

This commit also adds an `acr_values` property. This is looking forward to when parameters are consumed by the parser introduced in #9971.

[skip changelog]
  • Loading branch information
jmhooper authored Jan 29, 2024
1 parent e4ff006 commit 02e474b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion app/models/service_provider_request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ def initialize(
ial: nil,
aal: nil,
requested_attributes: [],
biometric_comparison_required: false
biometric_comparison_required: false,
acr_values: nil, # rubocop:disable Lint/UnusedMethodArgument
vtr: nil # rubocop:disable Lint/UnusedMethodArgument
)
@uuid = uuid
@issuer = issuer
Expand Down

0 comments on commit 02e474b

Please sign in to comment.