We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please follow helm and kubernetes standards for labels. See https://helm.sh/docs/chart_best_practices/labels/.
The text was updated successfully, but these errors were encountered:
Thank you for addressing. #21 will add these labels for all deployments, services, and secrets.
And what do you think, considering Helm's recommendation on not overdoing labels and listing the following as a condition:
It is useful to expose to operators for the purpose of querying the system.
Would you say these labels also belong on the CRD definition and RBAC resources?
Sorry, something went wrong.
I'm not sure what the standard is for CRDs, I would check out existing helm charts. I would definitely add the labels to the RBAC resources though.
florisvdg
Successfully merging a pull request may close this issue.
Please follow helm and kubernetes standards for labels. See https://helm.sh/docs/chart_best_practices/labels/.
The text was updated successfully, but these errors were encountered: