Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow helm and kubernetes standards for labels #11

Closed
nesl247 opened this issue Apr 13, 2021 · 3 comments · Fixed by #21
Closed

Follow helm and kubernetes standards for labels #11

nesl247 opened this issue Apr 13, 2021 · 3 comments · Fixed by #21
Assignees

Comments

@nesl247
Copy link

nesl247 commented Apr 13, 2021

Please follow helm and kubernetes standards for labels. See https://helm.sh/docs/chart_best_practices/labels/.

@florisvdg florisvdg self-assigned this Apr 15, 2021
@florisvdg florisvdg linked a pull request Apr 16, 2021 that will close this issue
@florisvdg
Copy link
Member

Thank you for addressing. #21 will add these labels for all deployments, services, and secrets.

And what do you think, considering Helm's recommendation on not overdoing labels and listing the following as a condition:

It is useful to expose to operators for the purpose of querying the system.

Would you say these labels also belong on the CRD definition and RBAC resources?

@nesl247
Copy link
Author

nesl247 commented Apr 16, 2021

I'm not sure what the standard is for CRDs, I would check out existing helm charts. I would definitely add the labels to the RBAC resources though.

1 similar comment
@nesl247
Copy link
Author

nesl247 commented Apr 16, 2021

I'm not sure what the standard is for CRDs, I would check out existing helm charts. I would definitely add the labels to the RBAC resources though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants