Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opgen: fix display of usage when no arguments (#44) #45

Merged
merged 1 commit into from
Jan 12, 2023
Merged

opgen: fix display of usage when no arguments (#44) #45

merged 1 commit into from
Jan 12, 2023

Conversation

dolmen
Copy link
Contributor

@dolmen dolmen commented Jan 11, 2022

Fix #44.

@dolmen
Copy link
Contributor Author

dolmen commented Jan 13, 2022

ping @DCKcode @jpgoldberg @mitchchn @robyoder (see also my other pull requests)

@dolmen
Copy link
Contributor Author

dolmen commented Feb 14, 2022

ping @jpgoldberg

@jpgoldberg
Copy link
Contributor

jpgoldberg commented Jan 12, 2023 •
edited
Loading

Thanks @dolman, I am very happy to defer to your knowledge of Go conventions. In this case, I am not seeing what is broken. The output looks to the same to me both with or without your fix. What am I missing?

Edit: I am missing reading the associated issue, #44, which spells it out.

@jpgoldberg jpgoldberg changed the base branch from master to release/v0.2.0 January 12, 2023 21:07
@jpgoldberg jpgoldberg merged commit 1ea0256 into 1Password:release/v0.2.0 Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opgen without arguments doesn't show usage
2 participants
@dolmen @jpgoldberg