Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if remote uses SSH #4

Open
1ec5 opened this issue Aug 7, 2018 · 1 comment
Open

Error if remote uses SSH #4

1ec5 opened this issue Aug 7, 2018 · 1 comment

Comments

@1ec5
Copy link
Owner

1ec5 commented Aug 7, 2018

The Open in GitHub workflow assumes the remote uses an HTTPS URL, which is what GitHub recommends by default. But it should also be possible to ascertain the webpage URL if the remote uses an SSH URL.

@1ec5
Copy link
Owner Author

1ec5 commented Sep 4, 2018

Actually, this line should already ensure that SSH URLs are converted to HTTPS URLs:

REPO_URL=${REPO_URL/#git@github.com:/https://github.com/}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant