-
Notifications
You must be signed in to change notification settings - Fork 0
/
commands_test.go
553 lines (470 loc) · 16.7 KB
/
commands_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
package main_test
import (
"errors"
. "github.com/1egoman/slick"
"github.com/1egoman/slick/gateway"
"github.com/1egoman/slick/gateway/slack"
"github.com/jarcoal/httpmock"
"net/http"
"testing"
"io"
"golang.org/x/net/websocket"
)
func TestRunCommand(t *testing.T) {
var command Command
var err error
state := NewInitialStateMode("writ")
// Test a native command
wasCalled := false
command = Command{
Name: "My Command",
Description: "Command Description",
Type: NATIVE,
Permutations: []string{"foo", "bar"},
Arguments: "<required> [optional]",
Handler: func(args []string, state *State) error {
wasCalled = true
return nil
},
}
err = RunCommand(command, []string{"foo"}, state)
if wasCalled && err != nil {
t.Errorf("Error in running valid command: %s (wascalled = %v)", err, wasCalled)
}
// Test a native command without a handler
command = Command{
Name: "My Command",
Description: "Command Description",
Type: NATIVE,
Permutations: []string{"foo", "bar"},
Arguments: "<required> [optional]",
Handler: nil,
}
err = RunCommand(command, []string{"foo"}, state)
if err.Error() != "The command My Command doesn't have an associated handler function." {
t.Errorf("Wrong error in running nil handler command: %s", err)
}
}
func TestGetCommand(t *testing.T) {
var command *Command
// Test a native command
command = GetCommand("Connect")
if command.Name != "Connect" {
t.Errorf("Invalid command found with GetCommand: %+v", command)
}
// Test a native command
command = GetCommand("CommandThatDoesntExist")
if command != nil {
t.Errorf("Unexpected command found by GetCommand: %+v", command)
}
}
func TestHttpBasedCommands(t *testing.T) {
defer httpmock.DeactivateAndReset()
for _, test := range []struct {
Name string
Command string
Args []string
Url string
Response string
Error error
}{
{
Name: `/postinline "post body" works`,
Command: "PostInline",
Args: []string{"postinline", "post body"},
Url: "https://slack.com/api/files.upload?token=token&channels=channel-id&content=post+body",
Response: `{"ok": true}`,
},
{
Name: `/postinline "post body" "post title" works`,
Command: "PostInline",
Args: []string{"postinline", "post body", "post title"},
Url: "https://slack.com/api/files.upload?token=token&channels=channel-id&content=post+body&title=post+title",
Response: `{"ok": true}`,
},
{
Name: `/postinline alone doesn't work`,
Command: "PostInline",
Args: []string{"postinline"},
Error: errors.New("Please use more arguments. /postinline \"post content\" [\"post title\"]"),
},
{
Name: `If /postinline throws underlying errors we know about it`,
Command: "PostInline",
Args: []string{"postinline", "post body", "post title"},
Url: "https://slack.com/api/files.upload?token=token&channels=channel-id&content=post+body&title=post+title",
Response: `{"ok": true, "error": "My Error"}`,
Error: errors.New("My Error"),
},
} {
// Listen for command response
httpmock.Activate()
httpmock.RegisterResponder("GET", test.Url, httpmock.NewStringResponder(200, test.Response))
// Create initial state
initialState := NewInitialStateMode("writ")
initialState.Connections = []gateway.Connection{
gatewaySlack.New("token"),
}
initialState.ActiveConnection().SetSelectedChannel(&gateway.Channel{Id: "channel-id"})
// Execute the command
command := GetCommand(test.Command)
err := command.Handler(test.Args, initialState)
httpmock.DeactivateAndReset()
// Verify the output
if !((test.Error == nil && err == nil) || (test.Error.Error() == err.Error())) {
t.Errorf("Test %s failed: %s", test.Name, err)
}
}
}
// Test `/connect token-here` and `/disconnect`
func TestCommandConnectDisconnect(t *testing.T) {
defer httpmock.DeactivateAndReset()
// Create a local websocket server for this test.
go func() {
http.Handle("/echo", websocket.Handler(func (ws *websocket.Conn) { io.Copy(ws, ws) }))
err := http.ListenAndServe(":12345", nil)
if err != nil {
panic("ListenAndServe: " + err.Error())
}
}()
// Listen for command response
httpmock.Activate()
httpmock.RegisterResponder("GET", "https://slack.com/api/rtm.start?token=token",
httpmock.NewStringResponder(200, `{"ok": true, "url": "ws://localhost:12345/echo"}`))
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.New("token"),
}
state.ActiveConnection().SetSelectedChannel(&gateway.Channel{Id: "channel-id"})
// Execute the command
command := *GetCommand("Connect")
err := RunCommand(command, []string{"connect", "token"}, state)
// Verify the output
if err != nil {
t.Errorf("Couldn't connect to mock slack: %s", err)
}
// Attempt to disconnect from the socket.
command = *GetCommand("Disconnect")
err = RunCommand(command, []string{"disconnect"}, state)
if err != nil {
t.Errorf("Couldn't disconnect from mock slack: %s", err)
}
}
// Test `/connect "team name" token-here`
func TestCommandConnectWithName(t *testing.T) {
defer httpmock.DeactivateAndReset()
// Create a local websocket server for this test.
go func() {
http.Handle("/echo2", websocket.Handler(func (ws *websocket.Conn) { io.Copy(ws, ws) }))
err := http.ListenAndServe(":12346", nil)
if err != nil {
panic("ListenAndServe: " + err.Error())
}
}()
// Listen for command response
httpmock.Activate()
httpmock.RegisterResponder("GET", "https://slack.com/api/rtm.start?token=token",
httpmock.NewStringResponder(200, `{"ok": true, "url": "ws://localhost:12346/echo2"}`))
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.New("token"),
}
state.ActiveConnection().SetSelectedChannel(&gateway.Channel{Id: "channel-id"})
// Execute the command
command := *GetCommand("Connect")
err := RunCommand(command, []string{"connect", "team name", "token"}, state)
// Verify the output
if err != nil {
t.Errorf("Couldn't connect to mock slack: %s", err)
}
if name := state.ActiveConnection().Name(); name != "team name" {
t.Errorf("Invalid name for slack team: %s", name)
}
}
// Test `/connect "team name" token-here` when the internet is disconnected.
// A new connection should be added, but it should be diconnected.
func TestCommandConnectWithInternetDisconnected(t *testing.T) {
defer httpmock.DeactivateAndReset()
// Listen for command response
httpmock.Activate()
httpmock.RegisterNoResponder(httpmock.InitialTransport.RoundTrip)
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.New("token"),
}
state.ActiveConnection().SetSelectedChannel(&gateway.Channel{Id: "channel-id"})
// Execute the command
command := *GetCommand("Connect")
err := RunCommand(command, []string{"connect", "team name", "token"}, state)
// Expect an error, since we are "offline"
if err == nil {
t.Errorf("Error expected, should have failed to connect since we are 'offline'")
}
if name := state.ActiveConnection().Name(); name != "team name" {
t.Errorf("Invalid name for slack team: %s", name)
}
// Status should be disconnected, because we are offline
if status := state.ActiveConnection().Status(); status != gateway.DISCONNECTED {
t.Errorf("Invalid connection status: %v", status)
}
}
func TestCommandPick(t *testing.T) {
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{
gateway.Channel{Name: "channel name", Id: "channel-id"},
gateway.Channel{Name: "other channel", Id: "other-channel-id"},
}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[1])
// Execute the command
command := *GetCommand("Pick")
err := RunCommand(command, []string{"pick", "team name", "channel name"}, state)
// Verify the output
if err != nil {
t.Errorf("Couldn't pick another team:", err)
}
if name := state.ActiveConnection().Name(); name != "team name" {
t.Errorf("Didn't choose slack team 'team name', used %s instead.", name)
}
if channel := state.ActiveConnection().SelectedChannel().Name; channel != "channel name" {
t.Errorf("Didn't choose slack channel 'channel name', used %s instead.", channel)
}
}
func TestCommandPickBadArgs(t *testing.T) {
// Create initial state
state := NewInitialStateMode("writ")
// Execute the command, with
command := *GetCommand("Pick")
err := RunCommand(command, []string{"pick" /* team name, channel name */}, state)
// Verify the output
if err.Error() != "Please specify more args. /pick <connection name> <channel name>" {
t.Errorf("Bad pick command args didn't emit right error: %s", err)
}
}
func TestCommandExpandAttachment(t *testing.T) {
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{gateway.Channel{Name: "channel name", Id: "channel-id"}}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[0])
state.ActiveConnection().SetMessageHistory([]gateway.Message{
gateway.Message{
Text: "My Message",
Attachments: &[]gateway.Attachment{
gateway.Attachment{
Title: "title",
Body: "body",
},
},
},
})
// Execute the command, with
command := *GetCommand("ExpandAttachment")
err := RunCommand(command, []string{"expandattachment", "1"}, state)
// Verify the output
if err != nil {
t.Errorf("Failed to open modal for expanding attachment: %s", err)
}
if state.Mode != "modl" {
t.Errorf("Mode not set to `modl`: %s", state.Mode)
}
if state.Modal.Title != "title" || state.Modal.Body != "body" {
t.Errorf("Modal title and body not set to the right values: %+v", state.Modal)
}
}
func TestCommandResendMessage(t *testing.T) {
// Mock the http request
userSentMessage := false
httpmock.Activate()
httpmock.RegisterResponder(
"GET",
"https://slack.com/api/chat.postMessage?token=token&channel=channel-id&text=foo&link_names=true&parse=full&unfurl_links=true&as_user=true",
func(req *http.Request) (*http.Response, error) {
userSentMessage = true
return httpmock.NewStringResponse(200, `{"ok": true}`), nil
},
)
defer httpmock.DeactivateAndReset()
// Create initial statez
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{gateway.Channel{Name: "channel name", Id: "channel-id"}}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[0])
state.ActiveConnection().SetMessageHistory([]gateway.Message{
gateway.Message{Text: "foo", Confirmed: false},
})
// Execute the command
command := *GetCommand("ResendMessage")
err := RunCommand(command, []string{"resendmessage"}, state)
// Verify the output
if err != nil {
t.Errorf("Failed to resend message", err)
}
if !userSentMessage {
t.Errorf("Message wasn't resent!")
}
}
func TestCommandResendMessageMessageWasntSentByUser(t *testing.T) {
// Mock the http request
httpmock.Activate()
httpmock.RegisterResponder(
"GET",
"https://slack.com/api/rtm.start?token=token",
httpmock.NewStringResponder(200, `{"ok": true, "self": {"name": "username"}}`),
)
defer httpmock.DeactivateAndReset()
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{gateway.Channel{Name: "channel name", Id: "channel-id"}}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[0])
state.ActiveConnection().SetMessageHistory([]gateway.Message{
gateway.Message{Text: "foo", Sender: &gateway.User{Name: "otheruser"}, Confirmed: false},
})
// Execute the command
command := *GetCommand("ResendMessage")
err := RunCommand(command, []string{"resendmessage"}, state)
// Verify the output
if err == nil || err.Error() != "Message was not originally sent by you." {
t.Errorf("Resent message that wasn't meant to be resent", err)
}
}
func TestCommandJoin(t *testing.T) {
// Mock the http response
httpmock.Activate()
// "Join" the channel
httpmock.RegisterResponder(
"GET",
"https://slack.com/api/channels.join?token=token&name=channel&validate=true",
httpmock.NewStringResponder(200, `{
"ok": true,
"channel": {"name": "channel", "is_member": true, "creator_id": "useridhere"}
}`),
)
defer httpmock.DeactivateAndReset()
// Create initial statez
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{gateway.Channel{Name: "channel", Id: "channel-id"}}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[0])
// Execute the command
command := *GetCommand("Join")
err := RunCommand(command, []string{"join"}, state)
// Verify the output
if err != nil {
t.Errorf("Failed to join channel", err)
}
if state.ActiveConnection().Channels()[0].IsMember == false {
t.Errorf("Channel under test wasn't joined!")
}
}
func TestCommandLeave(t *testing.T) {
// Mock the http response
httpmock.Activate()
// "Join" the channel
httpmock.RegisterResponder(
"GET",
"https://slack.com/api/channels.leave?token=token&channel=channel-id",
httpmock.NewStringResponder(200, `{"ok": true}`),
)
defer httpmock.DeactivateAndReset()
// Create initial statez
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{gateway.Channel{Name: "channel", Id: "channel-id"}}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[0])
// Execute the command
command := *GetCommand("Leave")
err := RunCommand(command, []string{"leave"}, state)
// Verify the output
if err != nil {
t.Errorf("Failed to leave channel", err)
}
if state.ActiveConnection().Channels()[0].IsMember == true {
t.Errorf("Channel under test wasn't left, .IsMember was true!")
}
}
func TestCommandLeaveNotAMemberOfChannel(t *testing.T) {
// Mock the http response
httpmock.Activate()
// "Join" the channel
httpmock.RegisterResponder(
"GET",
"https://slack.com/api/channels.leave?token=token&channel=channel-id",
httpmock.NewStringResponder(200, `{"ok": true, "not_in_channel": true}`),
)
defer httpmock.DeactivateAndReset()
// Create initial statez
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.NewWithName("team name", "token"),
}
channels := []gateway.Channel{gateway.Channel{Name: "channel", Id: "channel-id"}}
state.ActiveConnection().SetChannels(channels)
state.ActiveConnection().SetSelectedChannel(&channels[0])
// Execute the command
command := *GetCommand("Leave")
err := RunCommand(command, []string{"leave"}, state)
// Verify the output
if err.Error() != "User isn't in channel channel, so cannot leave!" {
t.Errorf("Didn't return an error when the user wasn't a member of the channel!")
}
if state.ActiveConnection().Channels()[0].IsMember == true {
t.Errorf(".IsMember on the channel was true, should have been kept false.")
}
}
// Test `/disconnect`ing from an already disconnected connection
func TestCommandDisconnectFromAlreadyDisconnectedConnection(t *testing.T) {
defer httpmock.DeactivateAndReset()
// Listen for command response
// FIXME: we should spin up a local websocket server here and not use one on the internet.
httpmock.Activate()
httpmock.RegisterNoResponder(httpmock.InitialTransport.RoundTrip)
// Create initial state
state := NewInitialStateMode("writ")
state.Connections = []gateway.Connection{
gatewaySlack.New("token"),
}
state.ActiveConnection().SetSelectedChannel(&gateway.Channel{Id: "channel-id"})
// Execute the command
command := *GetCommand("Connect")
err := RunCommand(command, []string{"connect", "team name", "token"}, state)
// Verify the connection failed (ie, connection is DISCONNECTED)
if err == nil {
t.Errorf("Connected to mock slack succesfully, should have failed")
}
if name := state.ActiveConnection().Name(); name != "team name" {
t.Errorf("Invalid name for slack team: %s", name)
}
// Now, disconnect
command = *GetCommand("Disconnect")
err = RunCommand(command, []string{"disconnect"}, state)
if err != nil {
t.Errorf("Couldn't disconnect from mock slack: %s", err)
}
if state.ActiveConnection().Status() != gateway.DISCONNECTED {
t.Errorf("Connection status isn't DISCONNECTED: %v", state.ActiveConnection().Status())
}
}