-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for propane level sensor (iGrillv3) #9
Comments
I just pushed an updated version to the propane branch that should work (or be close). Can you switch to that branch and then try that version and let me know the results. |
Line #288 in Line 288 in dce5b65
I uploaded the propane branch sketch to my esp32, but unfortunately I'm not seeing a propane sensor within Home Assistant or MQTT Explorer. I'm attempting to revive my laptop so that I can view the esp logs while being simultaneously within bluetooth range of the igrill (the desktop pc I'm using is not within bt range) . Hopefully the debug output while connected gives us some hints for needed changes. It might be worth noting that my propane tank is currently less than 25% full, so the reported value would be expected as "0". Thanks for getting started on this enhancement so swiftly! |
I made a small update to show if a propane sensor was setup in the systeminfo mqtt topic. Can you try the latest and let me know if in MQTT its showing propane sensor as true or false. |
MQTT is showing the following for propane sensor: I'm on software: |
Looks like it's not detecting that characteristic. Can you perform the steps below and attach a screenshot of the output here.
|
Here's what I've got from the nrfConnect app: Value Let me know whether there's anything else you'd like me to test. Thanks! |
Looks like the propane level is on its own service uuid which is why we weren't able to read that characteristic. I just pushed changes that hopefully should get us some values back. When you get a bit of free time can you pull the latest code and let me know the results. |
Oops realized after you replied that I forgot to change the UUID for the Propane service when I made the updates. Can you re-pull and try again. |
MQTT Explorer reports |
Just to confirm you unpaired your phone from the iGrill before testing? In your latest test is it still reporting the temps to mqtt? Did you happen to get your laptop running so we can get the debug logs for a closer look at what's happening? If not I'll need to make some updates to throw the debug logs to mqtt. |
I did unpair from my phone before re-testing with esp32. In latest, I was still seeing temperatures and battery reported to MQTT. I also tried forcing I just finished getting my laptop up and running and confirmed that I can see the serial monitor output from esp32 as it runs iGrill code. |
I just changed how the code is trying to detect if the propane service exists and added in some additional logging. Can you try pulling the most recent and then let me know if its showing in the Serial logs if it detects the propane service or not. |
Awesome!! Are you also running Home Assistant? If so after a restart of HA did the propane level sensor show up properly there too? |
I just pushed an update that should hopefully fix that issue. You'll likely need to delete the topics via MQTT explorer for things to show up properly. Then if all looks well in MQTT Explorer a restart of HA should get the propane level sensor discovered. |
After latest update, a propane sensor shows up under the igrill device in HA! The value was reported as "3%", which led me to believe the code for reporting value was missing a multiplication operation. On my local copy I found and changed Line#391 from |
Thank you! I just fixed and pushed that change. If everything else is working well I'll go ahead and push this to the main branch. |
For good measure I pulled latest and uploaded to the esp32 - it's working very well! Thanks for spending your time and effort to get this feature added. |
I just merged this into the main branch and added you to the contributions section in the readme. Thanks again for the help getting this working and tested. |
My iGrillv3 is equipped with a propane level sensor. The official iGrill app reports the propane level. I'm submitting this issue as a feature request to see the same level reporting functionality within esp32_iGrill.
f5d40001-3548-4c22-9947-f3673fce3cd9s
100, 75, 50, 25, or 0
float(bytearray(self.propane_level.read())[0])*25
The text was updated successfully, but these errors were encountered: