Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializers attr object is ignored during normalization #45

Open
makepanic opened this issue Feb 8, 2017 · 0 comments · May be fixed by #46
Open

serializers attr object is ignored during normalization #45

makepanic opened this issue Feb 8, 2017 · 0 comments · May be fixed by #46

Comments

@makepanic
Copy link
Contributor

attrs is currently ignored.

One could fix this by calling the private this.normalizeUsingDeclaredMapping json serializer method before extracting the attributes, relationships. This is how the json-api serializer does it: https://github.com/emberjs/data/blob/v2.11.0/addon/serializers/json-api.js#L409

I think it should be part of the hal serializer.
If you're interested i could open a PR to implement it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix serializer not using attrs before extracting attributes makepanic/ember-data-hal-9000
1 participant
@makepanic