Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Instancing #524

Open
Ilwyd opened this issue Feb 26, 2024 · 0 comments
Open

Issues with Instancing #524

Ilwyd opened this issue Feb 26, 2024 · 0 comments

Comments

@Ilwyd
Copy link
Contributor

Ilwyd commented Feb 26, 2024

Using this to keep track of issues found while experimenting with pre-existing instance code:

  • Overlay and Underlays are not present in the instanced area
  • Ground height data is not copied over
  • Objects flicker often while moving around the instance
    • Seems to be related to Chunk.sendUpdates. I think this runs every time the player moves.
    • Increasing the height value passed to UpdateZoneFullFollowsMessage results in 2 versions of the instance appearing where only the version with the higher height flickers (video 1)
    • The non-flickering version is created by UpdateZonePartialFollowsMessage
  • Teleing to the instance area after creating it results in a black screen. Does not happen when already in the instance area. (video 2)
    • Teleing out of the black screen results in the UpdateZoneFullFollowsMessage version of the instance appearing wherever you arrive
    • Related to RebuildRegionMessage.
      • Encoder and Message classes already exist
      • We don't currently have a packet structure defined for this.

Video 1 (Flickering)

java_GoSHX86M91.mp4

Video 2 (Teleing after creating instance)

idea64_LEQhCW4xEm.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant