Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Review #3

Open
gartician opened this issue Oct 25, 2018 · 0 comments
Open

Peer Review #3

gartician opened this issue Oct 25, 2018 · 0 comments

Comments

@gartician
Copy link

- Does the proposed algorithm make sense to you? Can you follow the logic?
The proposed algorithm is logical and makes sense.
- Does the algorithm do everything it's supposed to do? (see part 1)
Overall the algorithm is complete but need to include how to detect duplicates that are far away (in terms of line count) as Jason warned us.
- Are proposed functions reasonable? Are they "standalone" pieces of code?
The proposed functions are pretty reasonable and are ‘standalone’ pieces of code. The examples given with adjust_position() function were helpful for the reader.
Further comments: I would pseudocode using less actual code because in the future you may need to show to employers and they may not be super-good programmers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant