You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Does the proposed algorithm make sense to you? Can you follow the logic?
The proposed algorithm is logical and makes sense. - Does the algorithm do everything it's supposed to do? (see part 1)
Overall the algorithm is complete but need to include how to detect duplicates that are far away (in terms of line count) as Jason warned us. - Are proposed functions reasonable? Are they "standalone" pieces of code?
The proposed functions are pretty reasonable and are ‘standalone’ pieces of code. The examples given with adjust_position() function were helpful for the reader. Further comments: I would pseudocode using less actual code because in the future you may need to show to employers and they may not be super-good programmers.
The text was updated successfully, but these errors were encountered:
- Does the proposed algorithm make sense to you? Can you follow the logic?
The proposed algorithm is logical and makes sense.
- Does the algorithm do everything it's supposed to do? (see part 1)
Overall the algorithm is complete but need to include how to detect duplicates that are far away (in terms of line count) as Jason warned us.
- Are proposed functions reasonable? Are they "standalone" pieces of code?
The proposed functions are pretty reasonable and are ‘standalone’ pieces of code. The examples given with adjust_position() function were helpful for the reader.
Further comments: I would pseudocode using less actual code because in the future you may need to show to employers and they may not be super-good programmers.
The text was updated successfully, but these errors were encountered: