feat(train): add optional accumulate_grad_batches
config param
#306
+10
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
accumulate_grad_batches
param to thetrain
part of the config to allow for gradient accumulation. (Lightning docs)This updates the gradients once every
accumulate_grad_batches
batches, with a default value of 1 to not break any existing configs.I went with the same name (
accumulate_grad_batches
) as the argument toTrainer
, even though we're not actually using that argument due to doing manual optimization. I realize that might be confusing, so I'm open to suggestions.I'm relatively new to ML/AI work, so just to double-check my understanding:
manual_backward
backpropagates and accumulates gradientsstep
updates model parameterszero_grad
clears the gradientsSo calling
manual_backward
,step
,zero_grad
should be equivalent to callingzero_grad
,manual_backward
,step
.Other considerations:
retain_graph=True
because we backpropagate once for each forward pass