diff --git a/.github/workflows/integration-tests.yaml b/.github/workflows/test.yaml similarity index 77% rename from .github/workflows/integration-tests.yaml rename to .github/workflows/test.yaml index 275bf498..d9a79d74 100644 --- a/.github/workflows/integration-tests.yaml +++ b/.github/workflows/test.yaml @@ -1,4 +1,4 @@ -name: Integration tests +name: Test on: pull_request: @@ -30,5 +30,12 @@ jobs: make download make docker_volume_create make docker_up + - name: Run unit tests + run: make test + - name: Recreate volumes + run: | + make docker_down + make docker_volume_recreate + make docker_up_nobuild - name: Run integration tests run: make test_integration \ No newline at end of file diff --git a/.github/workflows/unit-tests.yaml b/.github/workflows/unit-tests.yaml deleted file mode 100644 index 6e1738a6..00000000 --- a/.github/workflows/unit-tests.yaml +++ /dev/null @@ -1,34 +0,0 @@ -name: Unit tests - -on: - pull_request: - branches: [ "develop", "master" ] - paths-ignore: - - "docs/**" - - "**.md" -# push: -# branches: [ "develop", "master" ] -# paths-ignore: -# - "docs/**" -# - "**.md" - -jobs: - - build: - - runs-on: ubuntu-latest - - steps: - - uses: actions/checkout@v4 - - name: Set up Docker Buildx - uses: docker/setup-buildx-action@v3 - - run: | - touch .env - echo BAG3D_TEST_DATA=${PWD}/tests/test_data >> .env - - name: Build docker images - run: | - make download - make docker_volume_create - make docker_up - - name: Run unit tests - run: make test \ No newline at end of file diff --git a/docker/compose.yaml b/docker/compose.yaml index 0f2dd95b..9a6c1d95 100644 --- a/docker/compose.yaml +++ b/docker/compose.yaml @@ -27,10 +27,10 @@ services: container_name: bag3d-data-postgresql healthcheck: test: ["CMD-SHELL", "pg_isready -d ${BAG3D_PG_DATABASE}"] - interval: 7s - retries: 7 - start_period: 60s - timeout: 30s + interval: 3s + retries: 10 + start_period: 30s + timeout: 10s shm_size: '1gb' ports: - "${BAG3D_PG_PORT_ON_HOST}:5432" diff --git a/docker/pipeline/bag3d-core.dockerfile b/docker/pipeline/bag3d-core.dockerfile index e074a7fe..8b2a396c 100644 --- a/docker/pipeline/bag3d-core.dockerfile +++ b/docker/pipeline/bag3d-core.dockerfile @@ -1,4 +1,4 @@ -FROM 3dgi/3dbag-pipeline-tools:2024.12.05 AS develop +FROM 3dgi/3dbag-pipeline-tools:2024.12.05-1 AS develop ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline LABEL org.opencontainers.image.authors="Balázs Dukai " diff --git a/docker/pipeline/bag3d-floors-estimation.dockerfile b/docker/pipeline/bag3d-floors-estimation.dockerfile index f15c1fd8..cecacb10 100644 --- a/docker/pipeline/bag3d-floors-estimation.dockerfile +++ b/docker/pipeline/bag3d-floors-estimation.dockerfile @@ -1,4 +1,4 @@ -FROM 3dgi/3dbag-pipeline-tools:2024.12.05 AS develop +FROM 3dgi/3dbag-pipeline-tools:2024.12.05-1 AS develop ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline LABEL org.opencontainers.image.authors="Balázs Dukai " diff --git a/docker/pipeline/bag3d-party-walls.dockerfile b/docker/pipeline/bag3d-party-walls.dockerfile index ca6f0a23..34234a49 100644 --- a/docker/pipeline/bag3d-party-walls.dockerfile +++ b/docker/pipeline/bag3d-party-walls.dockerfile @@ -1,4 +1,4 @@ -FROM 3dgi/3dbag-pipeline-tools:2024.12.05 AS develop +FROM 3dgi/3dbag-pipeline-tools:2024.12.05-1 AS develop ARG BAG3D_PIPELINE_LOCATION=/opt/3dbag-pipeline LABEL org.opencontainers.image.authors="Balázs Dukai " diff --git a/makefile b/makefile index f97164a5..b9d2f05d 100644 --- a/makefile +++ b/makefile @@ -43,6 +43,9 @@ docker_up_postgres: docker_up: BAG3D_DOCKER_IMAGE_TAG=$(BAG3D_DOCKER_IMAGE_TAG) docker compose -p $(COMPOSE_PROJECT_NAME) -f docker/compose.yaml up -d +docker_up_nobuild: + BAG3D_DOCKER_IMAGE_TAG=$(BAG3D_DOCKER_IMAGE_TAG) docker compose -p $(COMPOSE_PROJECT_NAME) -f docker/compose.yaml up -d --no-build + docker_watch: BAG3D_DOCKER_IMAGE_TAG=$(BAG3D_DOCKER_IMAGE_TAG) docker compose -p $(COMPOSE_PROJECT_NAME) -f docker/compose.yaml watch diff --git a/packages/common/src/bag3d/common/resources/__init__.py b/packages/common/src/bag3d/common/resources/__init__.py index 85000855..a9864780 100644 --- a/packages/common/src/bag3d/common/resources/__init__.py +++ b/packages/common/src/bag3d/common/resources/__init__.py @@ -50,7 +50,7 @@ data_dir=str(Path(os.getenv("BAG3D_FILESTORE")) / "integration_core") ) -# Configure for gilfoyle +# Configure for gilfoyle file_store_gilfoyle = FileStoreResource(data_dir="/data") file_store_gilfoyle_fastssd = FileStoreResource(data_dir="/fastssd/data") diff --git a/packages/core/src/bag3d/core/assets/reconstruction/reconstruction.py b/packages/core/src/bag3d/core/assets/reconstruction/reconstruction.py index a9070e9a..645e0822 100644 --- a/packages/core/src/bag3d/core/assets/reconstruction/reconstruction.py +++ b/packages/core/src/bag3d/core/assets/reconstruction/reconstruction.py @@ -179,7 +179,8 @@ def create_roofer_config( source = {ahn5_files} [output-attributes] - status = "b3_status" + success = "b3_status" + extrusion_mode = "b3_extrusiemodus" reconstruction_time = "b3_t_run" val3dity_lod12 = "b3_val3dity_lod12" val3dity_lod13 = "b3_val3dity_lod13"