Skip to content
This repository has been archived by the owner on Jun 10, 2024. It is now read-only.

title edit followup fixes #311

Closed
kfarr opened this issue Oct 18, 2023 · 1 comment
Closed

title edit followup fixes #311

kfarr opened this issue Oct 18, 2023 · 1 comment
Assignees

Comments

@kfarr
Copy link
Contributor

kfarr commented Oct 18, 2023

Task: use system "prompt" dialog for editing title

Background:

  • there are console errors related to the original PR that was merged
  • there are also many usability issues with the custom styling of the new input widget used to edit title in the editor view [see below List1 - FYI only]

Instead of continuing to address these issues, I'd request instead the following behavior change:

  • Upon click, use javascript prompt with default text as the current title to allow for editing of the title. If the user presses OK without editing, then do not change the title. If the value is different than the default provided, then update the title.
  • The non-hover and hover behavior is the same, only click action is different

List1 - FYI only do not do these - issues with custom input widget for future development

  • pressing x on edit title should cancel edits, not set title to ''
  • as a user, after hovering and then clicking on a title I expect the title to be selected
  • pressing pencil icon on a scene with a blank title should start a cursor blinking at the beginning of the input box
@kfarr
Copy link
Contributor Author

kfarr commented Oct 26, 2023

closed by #319

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants