Merge pull request mrdoob#1 from agargaro/trackballcontrolszoom

Trackball zoom limit
3jsLive · Mar 2, 2023 · bd5d9e5 · bd5d9e5
2 parents 5fcbe5a + 85bedf7
commit bd5d9e5
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/examples/jsm/controls/TrackballControls.js b/examples/jsm/controls/TrackballControls.js
@@ -1,5 +1,6 @@
 import {
 	EventDispatcher,
+	MathUtils,
 	MOUSE,
 	Quaternion,
 	Vector2,
@@ -205,8 +206,13 @@ class TrackballControls extends EventDispatcher {
 
 				} else if ( scope.object.isOrthographicCamera ) {
 
-					scope.object.zoom /= factor;
-					scope.object.updateProjectionMatrix();
+						scope.object.zoom = MathUtils.clamp(scope.object.zoom / factor, scope.minDistance, scope.maxDistance);
+
+						if (lastZoom != scope.object.zoom) {
+
+							scope.object.updateProjectionMatrix();
+
+						}
 
 				} else {
 
@@ -226,8 +232,13 @@ class TrackballControls extends EventDispatcher {
 
 					} else if ( scope.object.isOrthographicCamera ) {
 
-						scope.object.zoom /= factor;
-						scope.object.updateProjectionMatrix();
+						scope.object.zoom = MathUtils.clamp(scope.object.zoom / factor, scope.minDistance, scope.maxDistance);
+
+						if (lastZoom != scope.object.zoom) {
+
+							scope.object.updateProjectionMatrix();
+
+						}
 
 					} else {