Stuck on image scaling

[chipsenkbeil]

I'm working on finishing up a talk for neovimconf this year, and one thing I'm doing is capturing a screenshot of a webpage to show in neovim, which I display using this plugin.

I can't seem to get the screenshot to properly fill the window I'm creating. If I supply a geometry, I can make the image smaller, but what you see here is as big as I can get it. Is there support for filling a buffer with a single image? Any tips on how to do this? I can confirm that the image is bigger at (Pixel Height: 683, Pixel Width: 1,366) than what is shown. So it isn't the case that the screenshot is actual size.

Code Example

I've tried creating the image and rendering with custom geometries. I've tried hijacking the buffer. Doing an image setup with maximum height set to nil doesn't do anything. Same if I set the height percentage to 100.

local api = require("image")
local image_path = "path/to/image.png"

-- Create a scratch buffer that is wiped once hidden
local buf = vim.api.nvim_create_buf(false, true)
vim.api.nvim_buf_set_option(buf, "bufhidden", "wipe")
vim.api.nvim_buf_set_keymap(buf, "n", "<ESC>", "<CMD>close<CR>", { noremap = true, silent = true })
vim.api.nvim_buf_set_keymap(buf, "n", "q", "<CMD>close<CR>", { noremap = true, silent = true })

-- Create a floating window using the scratch buffer positioned in the middle
local height = math.ceil(vim.o.lines * 0.8)  -- 80% of screen height
local width = math.ceil(vim.o.columns * 0.8) -- 80% of screen width
local win = vim.api.nvim_open_win(buf, true, {
    style = "minimal",
    relative = "editor",
    width = width,
    height = height,
    row = math.ceil((vim.o.lines - height) / 2),
    col = math.ceil((vim.o.columns - width) / 2),
    border = "single",
})

-- Load the image from disk and display it within our floating window
local image = api.from_file(image_path, { window = win, buffer = buf })

-- Render the image into the buffer
image:render()

-- Change to the window that is floating
vim.api.nvim_set_current_win(win)

[3rd]

Hey, sorry for the trouble, could you try setting max_height_window_percentage = 100 and checking if that works?
Doing this should be enough:

require("image").hijack_buffer("file.png", winnr, bufnr)

[3rd]

Yep, please share <3
Are you rendering a web view (something like https://github.com/chase/awrit)?

[chipsenkbeil]

Yep, please share <3

Added you as a collaborator to https://github.com/chipsenkbeil/neovimconf-2024-talk

You can run the example by doing nvim -u scripts/003_webview.lua from the root of the repository and then run :Webview https://chipsenkbeil.com or some other website. Make sure it's the full address including https. This is demo code, so it breaks fairly easily. 😄

Oh, and you need to clone with submodules because I have image.nvim as a submodule since it's a dependency for the 3rd example.

This is the particular code I've been referencing: https://github.com/chipsenkbeil/neovimconf-2024-talk/blob/main/scripts/003_webview/webview/lua/webview/viewer.lua

Are you rendering a web view (something like https://github.com/chase/awrit)?

No, I'm running headless firefox using marionette. I connect over TCP via neovim's luv TCP interface and communicate via the marionette protocol to take a screenshot. I get the screenshot as base64 encoded, so I save it to a file to load up using image.nvim.

[3rd]

Hmm, first thanks for this, got around to fixing partial rendering while scrolling.
To make scroll work we use extmarks to inject virtual space, but when scrolling Neovim will jump directly to the end of the extmark instead of smooth scrolling.
Maybe there is a way to make it not do that? It's either a missing functionality or a bad default.

https://gist.ro/browser.mp4

[3rd]

We can connect on Discord if you want.

[chipsenkbeil]

https://gist.ro/browser.mp4

Very nice! Would love to see what you did.

We can connect on Discord if you want.

Sure, I can do that.