-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace luafilesystem-ffi to fix build issue on aarch64 #1445
Conversation
it would be good to have verification steps |
Is there an easy way to build ARM docker image on x86 host? Is there an easy way to run ARM docker image on x86 host? |
Docker supports building arm images on x86 with |
Can you elaborate more on that? Is this PR still in progress? (the title says "do not merge"). Then, what is missing? (other that CHANGELOG.md) |
I'm using this on my x86 laptop https://github.com/multiarch/qemu-user-static with QEMU.
This is more like a test PR so @gsaslis can trigger a build for arm64 using code in this branch. I have provided 2 patches, 1 adds a new structure to If the first patch works then great, everyone happy |
a34e36a
to
f10c200
Compare
f10c200
to
5f1ad8d
Compare
@tkan145 it looks like some CI checks are still failing. Please ping me here once those are taken care of, so I can adapt the product build accordingly. ;) |
@gsaslis all the tests passed now 😄 |
This is a
experimental PR, replace the lfs-ffi https://github.com/3scale/luafilesystem-ffi/blob/master/lfs_ffi.lua#L921 with https://github.com/lunarmodules/luafilesystem tohopefullyfix the issue on arm64 https://issues.redhat.com/browse/THREESCALE-10662.Verification Steps
The lfs module is mainly used during startup, so the criteria is to have the APIcast start without errors.
The gateway should be running without error