[THREESCALE-11435] Check for nil value when decode based64 value #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing a match on a nil value results in an exception being thrown and bypassing the entire authorization validation process.
tkan145
changed the title
eguzki
approved these changes
Nov 15, 2024
|
It is failing http://search.cpan.org/~agent/Test-Nginx/lib/Test/Nginx/Socket.pm Maybe replace that with https://metacpan.org/pod/Test::Nginx |
I will address this with the next PR, need to fix on the main branch too |
This was referenced Nov 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Backport #1505 to 2.15 branch