Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails in code workflows #18

Closed
403-html opened this issue Jan 29, 2022 · 2 comments · Fixed by #23
Closed

Fails in code workflows #18

403-html opened this issue Jan 29, 2022 · 2 comments · Fixed by #23
Assignees
Labels
bug Something isn't working patch

Comments

@403-html
Copy link
Owner

No description provided.

@403-html 403-html added bug Something isn't working patch labels Jan 29, 2022
@403-html 403-html self-assigned this Jan 29, 2022
@403-html
Copy link
Owner Author

403-html commented Jan 29, 2022

Fails are in workflow because function is long, probably it'll need some refactor for "easy win", or it'd have to wait for full script refactor.

Sample:

{
    "id": 1243588,
    "status": "Done",
    "revision": "9319b80a1062214de02f93e1a5a5931d1f764792",
    "slocs": 314,
INFO:code-inspector:long function rate 0.07692307692307693 is higher than maximum 0.0001
    "techdebt": {
        "grade": "Excellent",
        "score": 100
    },
    "summary": {
        "duplicates": 0,
        "violations": 0,
        "duplicated_lines": 0,
        "longFunctions": 1,
        "totalFunctions": 13,
        "complexFunctions": 0
    }
}

@403-html 403-html linked a pull request Jan 30, 2022 that will close this issue
@403-html
Copy link
Owner Author

403-html commented Jan 30, 2022

Even with moving helpers outside of function (no nesting) I get error with HIGHER points

INFO:code-inspector:long function rate 0.08333333333333333 is higher than maximum 0.0001

So it looks like the "file" is treated as a function. So there is a need to edit the workflow to work with that. I understand and agree that files should not be large, but this one is not that large. So I'll move workflow to the 0.1 threshold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant