Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Telegram/* edits on Matrix #1015

Closed
Mikaela opened this issue Feb 23, 2020 · 4 comments
Closed

Handle Telegram/* edits on Matrix #1015

Mikaela opened this issue Feb 23, 2020 · 4 comments
Labels
enhancement New feature or request matrix

Comments

@Mikaela
Copy link

Mikaela commented Feb 23, 2020

Is your feature request related to a problem? Please describe.

When a message is sent from Telegram to Matrix and edited, it appears at Matrix with the (edited) suffix rather than the original message getting edited.

Describe the solution you'd like

I would like Matterbridge to edit the message it has relayed, I think the specification is somewhere in https://matrix.org/docs/spec/client_server/r0.6.0

Describe alternatives you've considered

I don't see other alternatives than the current behaviour and this request.

Additional context
-

@Mikaela Mikaela added the enhancement New feature or request label Feb 23, 2020
@MayeulC
Copy link

MayeulC commented Feb 24, 2020

Matrix has support for this, but it currently sits in matrix-org/matrix-spec-proposals#1849 which isn't yet part of the spec. There is one notable difference with the current (temporary) implementation, in that m.relationship is currently m.relates_to. Otherwise, the implementation is as-described. Not sure if best to implement now or once the MSC is merged?

Edit: one comment on that MSC said that clients could send both events during the transition period.

@Mikaela
Copy link
Author

Mikaela commented Feb 24, 2020

I think it may be better to wait

@Sorunome
Copy link

Sorunome commented Jul 1, 2020

The MSC seems mostly stale currently? with little activity.

Clients do, however, already implement editing with m.relates_to. If that MSC goes through with m.relationship a change would be trivial to adapt it, though it is probably more likely that the MSC changes to m.relates_to.

@42wim 42wim added the matrix label Dec 6, 2020
@42wim
Copy link
Owner

42wim commented Dec 6, 2020

Fixed with #1286

@42wim 42wim closed this as completed Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request matrix
Projects
None yet
Development

No branches or pull requests

4 participants