fix: Routing misses searchParams on mount #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franky47
changed the title
|
Tests included here pass under vercel/next.js#58861. |
franky47
force-pushed
the
fix/routing-tour
branch
from
880c871
to
15933cd
Compare
franky47
force-pushed
the
fix/routing-tour
branch
from
f1f2f32
to
fe1fd0e
Compare
|
🎉 This PR is included in version 1.13.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.13.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When init'ing a hook, it sometimes fails to pick up the correct value for the search params. Adding an end-to-end test for the routing tour which should cover all possible cases.
next@14.0.4-canary.37by Ensure original history is read in effect vercel/next.js#58861windowHistorySupportflag, and 14.0.4 no longer needs itlatesttests pass on CI).Closes #416.