Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: relax numpy constraint #1143

Merged
merged 3 commits into from
Jul 14, 2024
Merged

chore: relax numpy constraint #1143

merged 3 commits into from
Jul 14, 2024

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jul 13, 2024

As a new release of mahotas is numpy 2.0 compatybile then constraitn on numpy is no longer needed

Summary by CodeRabbit

  • Dependencies
    • Removed the upper version constraint for the numpy dependency, allowing the latest versions to be used.

As a new release of mahotas is numpy 2.0 compatybile then constraitn on numpy is no longer needed
@Czaki Czaki added this to the 0.15.4 milestone Jul 13, 2024
Copy link
Contributor

coderabbitai bot commented Jul 13, 2024

Walkthrough

These changes focus on adjusting the dependency management for the project. The upper version constraint for numpy in pyproject.toml has been removed, allowing for any version greater than or equal to 1.18.5. Additionally, numpy has been added as a new dependency in .github/project_dict.pws.

Changes

File Summary
pyproject.toml Removed the upper version constraint for the numpy dependency.
.github/project_dict.pws Added numpy as a new dependency.

Poem

In code we trust, with changes bright,
Dependencies shifting, taking flight.
Numpy unleashed, no bounds to bind,
In the matrix of progress, forward we find.
🎉🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bfb4d59 and 578d34d.

Files selected for processing (1)
  • pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (1)
  • pyproject.toml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 578d34d and a13410c.

Files selected for processing (1)
  • .github/project_dict.pws (2 hunks)
Additional comments not posted (1)
.github/project_dict.pws (1)

10-10: Approved: Addition of numpy to the personal word list.

The addition of numpy to the personal word list for spell checking is consistent with the PR objective of relaxing the numpy constraint.

Copy link

sonarcloud bot commented Jul 13, 2024

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (fc58344) to head (9ec1e48).
Report is 58 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1143      +/-   ##
===========================================
+ Coverage    93.01%   93.02%   +0.01%     
===========================================
  Files          207      207              
  Lines        32656    32656              
===========================================
+ Hits         30374    30379       +5     
+ Misses        2282     2277       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki merged commit 733b168 into develop Jul 14, 2024
58 checks passed
@Czaki Czaki deleted the relax_numpy_constraint branch July 14, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant