-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: relax numpy constraint #1143
Conversation
As a new release of mahotas is numpy 2.0 compatybile then constraitn on numpy is no longer needed
WalkthroughThese changes focus on adjusting the dependency management for the project. The upper version constraint for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/project_dict.pws (2 hunks)
Additional comments not posted (1)
.github/project_dict.pws (1)
10-10
: Approved: Addition ofnumpy
to the personal word list.The addition of
numpy
to the personal word list for spell checking is consistent with the PR objective of relaxing the numpy constraint.
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1143 +/- ##
===========================================
+ Coverage 93.01% 93.02% +0.01%
===========================================
Files 207 207
Lines 32656 32656
===========================================
+ Hits 30374 30379 +5
+ Misses 2282 2277 -5 ☔ View full report in Codecov by Sentry. |
As a new release of mahotas is numpy 2.0 compatybile then constraitn on numpy is no longer needed
Summary by CodeRabbit
numpy
dependency, allowing the latest versions to be used.