Add a setting to warn about deprecated instructions #5755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
D8H
commented
Oct 10, 2023
•
D8H
commented
| } | ||
| > | ||
| <Warning style={{ color: warningColor }} /> | ||
| </IconButton> |
There was a problem hiding this comment.
I think you can avoid using an IconButton (this isn't really a button as you can't interact)
I'd go for wrapping the with a <Tooltip></Tooltip> from material-ui directly (check other parts of the code)
I would also suggest using fontSize="small" for the warning component, so that it stays quite small and doesn't increase the height of the line?
There was a problem hiding this comment.
Yep, definitely go for a smaller size. I'm always a bit afraid of using material ui stuff directly in the events sheet, which is fairly performance sensible. Tooltip is fine though, and just the icon if possible (no IconButton)
4ian
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.