Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HTTP error status responses to M1_ContentHostingProvisioning_purgeContentHostingCache operation #40

Closed
rjb1000 opened this issue Jan 5, 2023 · 8 comments
Assignees
Labels
3GPP Rel-16 Issues relating to 3GPP Release 16 specifications. 3GPP Rel-17 Issues relating to 3GPP Release 17 specifications. 3GPP TS 26.512 Issues relating to SA4's "5G Media Streaming (5GMS); Protocols" specification. 5GMS Content Hosting Improvement

Comments

@rjb1000
Copy link
Contributor

rjb1000 commented Jan 5, 2023

Description

The YAML definition of the M1_ContentHostingProvisioning_purgeContentHostingCache operation does not currently specify HTTP response status codes for any error cases.

Suggested solution

It is proposed to add at least the following status codes:

  • 404 (Not Found) to cover the error case where a non-existent Provisioning Session ID is cited in the request URL.
  • 413 (Payload Too Large) to cover the error case where the POST message body (supplying the regular expression) is unreasonably large.
  • 415 (Unsupported Media Type) to cover the error case where the POST message has an unrecognised Content-Type.
  • 422 (Unprocessable Entity) to cover the error case where the POST message body (supplying a regular expression) is found to be syntactically invalid. For example:
    • The message body does not conform to the required x-www-form-urlencoded syntax.
    • The supplied regular express does not conform to the required syntax (e.g. the regular expression parser threw an error when attempting to compile it).

Additional context

This issue arose from the 5G-MAG/rt-5gms-application-server#52 and 5G-MAG/rt-5gms-application-function#18.

@rjb1000 rjb1000 added Improvement 3GPP Rel-16 Issues relating to 3GPP Release 16 specifications. 3GPP Rel-17 Issues relating to 3GPP Release 17 specifications. 3GPP TS 26.512 Issues relating to SA4's "5G Media Streaming (5GMS); Protocols" specification. labels Jan 5, 2023
@rjb1000 rjb1000 added this to the 3GPP SA4#122→SA#99 milestone Jan 5, 2023
@rjb1000 rjb1000 self-assigned this Jan 5, 2023
@davidjwbbc
Copy link

The 422 code may need adding to TS 29.500 Table 5.2.7.1-1 as it is not there at present.

@rjb1000
Copy link
Contributor Author

rjb1000 commented Jan 16, 2023

The 422 code may need adding to TS 29.500 Table 5.2.7.1-1 as it is not there at present.

Not sure whether a change to TS 29.500 is required or not.

That specification is under the control of CT4 rather than SA4, so any change will require formal liaison.

SA4 has some wriggle room to define M1 and M3 as it pleases since neither reference point is formally a Service-Based Interface in the 5G System.

@rjb1000
Copy link
Contributor Author

rjb1000 commented Jan 26, 2023

After internal discussion, we think it would be useful to the 5GMSd Application Provider invoking this operation to be able to distinguish between two success cases at M1:

  • Request was fine, but no cache entries matched the regular expression.
    • 204 (No Content) with no response body.
  • Request was fine, and some cache entries were purged.
    • 200 (OK) response including a JSON response body containing a single integer counting the total number of cache entries purged across the estate of 5GMSd AS instances that are currently configured to distribute the Provisioning Session in question.

@rjb1000
Copy link
Contributor Author

rjb1000 commented Jan 26, 2023

@davidjwbbc: We should allow both 204 (No Content) and 200 (OK) at reference point M3 as well.

Please can you link to a suitable PR on 5G-MAG/rt-common-shared.

@rjb1000
Copy link
Contributor Author

rjb1000 commented Feb 24, 2023

Contributions to 3GPP SA4#122 addressing this issue:

@rjb1000
Copy link
Contributor Author

rjb1000 commented Feb 24, 2023

Contributions revised and approved at 3GPP SA4#122 Closing Plenary:

@rjb1000
Copy link
Contributor Author

rjb1000 commented Mar 24, 2023

CR pack SP-250253 approved at SA#99 Plenary meeting in Rotterdam.

@rjb1000
Copy link
Contributor Author

rjb1000 commented Mar 31, 2023

New specifications published by 3GPP MCC:

(Transcription into equivalent ETSI Technical Specifications to follow in due course.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3GPP Rel-16 Issues relating to 3GPP Release 16 specifications. 3GPP Rel-17 Issues relating to 3GPP Release 17 specifications. 3GPP TS 26.512 Issues relating to SA4's "5G Media Streaming (5GMS); Protocols" specification. 5GMS Content Hosting Improvement
Projects
Development

No branches or pull requests

3 participants