Speeding up a Safe creation leads to error in UI and failure of retry

[tschubotz]

Title/Description

Speeding up a Safe creation leads to error in UI and failure of retry

Environment

• Browser: Firefox

• Wallet: MM

• App Version: 3.6.5

• Environment:

  • production (mainnet)

Steps to reproduce

1. Create a Safe (1 owner, threshold 1)
2. When Metamask pops up set a gas price so that it would take several hours to get mined. (tx)
3. Now speed up the tx in metamask so it would get mined (tx)
4. -> Now the Safe UI shows error (see screenshot below)
5. Click retry
6. Submit tx so it would get mined
7. Tx fails on chain (tx)

Expected result

• When a tx was sped up, I expect that the Safe UI doesn't show me a failed Safe creation
• In case I actually got a failed Safe creation, I would expect that "retry" would create a new valid tx that doesn't fail.

Screenshots

How to fix

@tschubotz:

We cannot detect if a tx was sped up. But a proper fix would be checking for the wallet created event on chain since we know the resulting safe address upfront.

[fernandomg]

we should keep an eye on web3/web3.js#3723

[katspaugh]

The latest code for this issue is on this branch by Fer.