This repository has been archived by the owner on Jun 5, 2023. It is now read-only.
feat: add button loading state and right arrow icon, #163 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diondiondion
approved these changes
May 3, 2022
There was a problem hiding this comment.
Thanks Sarah, this looks great 🙏
I just left a few comments, and if you could add a little storybook story for accessibility testing that'd be great. :)
And while the Button tests are very spotty at the moment, it would probably still be a good idea to add a test for the accessible attributes and test content of the loading state. I just noticed that there's a slight risk that the loading text will be smushed together with the button label for the accessible label, e.g. "NextLoading…". Have to make sure that doesn't happen.
|
🎉 This PR is included in version 14.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #163
TSIA
Untitled.mov