Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Implement Serilaize on response types #65

Closed
djrodgerspryor opened this issue Apr 12, 2023 · 3 comments
Closed

Feature Request: Implement Serilaize on response types #65

djrodgerspryor opened this issue Apr 12, 2023 · 3 comments

Comments

@djrodgerspryor
Copy link
Contributor

I'm trying to cache openai responses so that my tests will produce deterministic results, but the response types defined in this library don't implement Serialize, so I have to maintain a copy of them which does.

Would you be open to adding Serialize to all of the response types? This obviously increases the amount of generated code, but it makes consuming the data in cases like mine much easier.

@64bit
Copy link
Owner

64bit commented Apr 12, 2023

Hi @djrodgerspryor ,

Thank you for describing your use case and also implementing it!

So far async-openai has been mostly written to favor usefulness over any optimizations. So its all good.

@64bit
Copy link
Owner

64bit commented Apr 12, 2023

This is released in v0.10.3

@djrodgerspryor
Copy link
Contributor Author

Thanks for the quick, helpful response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants