Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PureConfig backend for distage-config #790

Closed
neko-kai opened this issue Dec 17, 2019 · 2 comments
Closed

PureConfig backend for distage-config #790

neko-kai opened this issue Dec 17, 2019 · 2 comments

Comments

@neko-kai
Copy link
Member

Unfortunately, circe-config is subject to some bugs that make it not preserve the meaning of original HOCON with 100% accuracy, e.g.

The principal reason for choosing circe-config over pureconfig in the first place was being able to use fast macros from circe-derivation to contain the penalty for compile-time codec derivation. pureconfig uses shapeless as its main derivation driver, so it's less than ideal for compile-times.
However, recently a magnolia-based deriver for pureconfig was merged: pureconfig/pureconfig#609 – but not released yet. With this change, pureconfig may be good enough to replace circe-config as a distage-config backend.

@neko-kai
Copy link
Member Author

neko-kai commented Jan 4, 2020

@neko-kai
Copy link
Member Author

Compile-time seems to have decreased from 39s to 34s following the change, so pureconfig-magnolia is likely good enough wrt compile-time

@pshirshov pshirshov modified the milestones: 0.12, 0.11 Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants