Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot doesn't realize it's version on released binary (2.1.0-) #55

Closed
9-9-9-9 opened this issue Oct 11, 2021 · 0 comments · Fixed by #54
Closed

Bot doesn't realize it's version on released binary (2.1.0-) #55

9-9-9-9 opened this issue Oct 11, 2021 · 0 comments · Fixed by #54
Assignees
Labels
bug Something isn't working

Comments

@9-9-9-9
Copy link
Owner

9-9-9-9 commented Oct 11, 2021

For documentation purpose

2.1.0 and earlier versions, bot able to know it's release version when having source code (pom.xml) file because it reads from it.

But on released versions (zip files) bot can't because the pom.xml file wasn't included into the release

So from 2.2.0 (PR#54), an additional file named current-version.txt was added to resources folder and bot can read it's version from it

Consequence:

  • From 2.1.0, the feature to save current version was made, but won't work until 2.2.0
  • From 1.7.0, the feature to check for new updates was made, but won't work until 2.2.0
@9-9-9-9 9-9-9-9 added the bug Something isn't working label Oct 11, 2021
@9-9-9-9 9-9-9-9 self-assigned this Oct 11, 2021
@9-9-9-9 9-9-9-9 linked a pull request Oct 11, 2021 that will close this issue
@9-9-9-9 9-9-9-9 closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant