Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make usage of omitempty tag optional #2649

Merged

Conversation

dcarbone
Copy link
Contributor

This PR provides developers with the ability to globally configure whether or not generated models have the ,omitempty json field tag applied when the field is nullable in the schema.

I have:

  • Added tests covering the bug / feature (see testing)
  • Updated any relevant documentation (see docs)

@coveralls
Copy link

coveralls commented May 26, 2023

Coverage Status

Coverage: 78.997%. Remained the same when pulling 3964db4 on dcarbone:dcarbone/optional-omitempty into 7ab3317 on 99designs:master.

@dcarbone dcarbone force-pushed the dcarbone/optional-omitempty branch from f4f4e6b to 3964db4 Compare May 26, 2023 17:50
@StevenACoffman StevenACoffman merged commit adf5da2 into 99designs:master May 26, 2023
@StevenACoffman
Copy link
Collaborator

Thanks!

@dcarbone dcarbone deleted the dcarbone/optional-omitempty branch May 26, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants