Adding entity resolver fix for entityResolver(multi: true) directive #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RyanMcCabe-catapult thanks for trying to fix this. This isn't the best way to implement this. Inside of plugin/federation.go you should add |
|
This fix has already landed. If you use the newest version this should be working for you now. |
|
Thanks @clayne11, Just noticed that when I synced with latest. I'll close out the PR and the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for the issue described in issue 3160. If the multi entity is used in any other resolver the error would always be thrown, now it is just skipped. The multi entity resolver has the directive set and runs it, the other resolvers don't have it set so it gets skipped and works as expected.
I have: