Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable YouTube support in groups #12

Closed
Armin2208 opened this issue May 18, 2020 · 7 comments
Closed

Disable YouTube support in groups #12

Armin2208 opened this issue May 18, 2020 · 7 comments

Comments

@Armin2208
Copy link

Your bot works great and helps us sharing music, because nearly everyone of us uses a different music streaming service.

But one thing has annoyed us. The bot also removes YouTube links and turns them to odesli bot music messages. Even though we didn't share a music video, just a normal video.

It would be nice if you would add a option to disable YouTube link support in groups. Thanks!

@AlexWayfer
Copy link

Or maybe it should get a video category (there is "Music" possible) and convert only music videos.

@9dogs
Copy link
Owner

9dogs commented May 18, 2020

Oh man, I've completely overlooked that case! From a quick glance at YouTube API, we can check category fairly easy, but will it be enough to resolve the annoyance? There are a lot of music videos/concerts which are YouTube-specific, those links should bypass the bot completely.

I guess the choice here is between:

  • disable YouTube links handling in group chats completely (in bright future it should be possible to disable it per-chat)
  • leave YouTube links handling for "Music" category only with a chance of "false positives" from time to time

@AlexWayfer
Copy link

@9dogs please, be aware of YouTube API rate limits, especially free ones.

@fronbasal
Copy link
Contributor

@9dogs I believe it would be sane to disable YouTube links in groups, as there are many groups sharing such links. I believe it is better to allow YouTube links for the inline Bot API and direct messaging.

@9dogs
Copy link
Owner

9dogs commented Jul 15, 2020

Sorry for the delay. Yes, it is indeed a good temporary solution (well, you know these temporary solutions 😃). Corresponding changes are pushed to master.
@Armin2208, could you check YouTube links now? Should be better.

@9dogs
Copy link
Owner

9dogs commented Jul 17, 2020

I'm closing the issue, feel free to reopen if I've missed something.

@9dogs 9dogs closed this as completed Jul 17, 2020
@Armin2208
Copy link
Author

works nice thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants