You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not entirely sure which of your libraries is responsible for this bug, but either case looks like a pretty easy fix. (I've submitted an issue to superagent-mocker as well: KyleAMathews/superagent-bluebird-promise#53)
If you want, I can submit a PR to change
cb&&cb(response,null);
to
cb&&cb(response,undefined);
or
cb&&cb(response);
Either change could be a quick fix for my issue.
Thanks for taking your time to contribute this very useful library to the OSS community!
The text was updated successfully, but these errors were encountered:
I'm using your library in conjunction with
superagent-bluebird-promise
, but it seems not to work for non-200 responses.The following
superagent-bluebird-promise
code ends up causing an error:From: https://github.com/KyleAMathews/superagent-bluebird-promise/blob/master/index.js#L66-L67
This is happening when
superagent-mocker
calls that function withres
passed in asnull
rather thanundefined
.From: https://github.com/A/superagent-mocker/blob/master/index.js#L99-L100
I'm not entirely sure which of your libraries is responsible for this bug, but either case looks like a pretty easy fix. (I've submitted an issue to superagent-mocker as well: KyleAMathews/superagent-bluebird-promise#53)
If you want, I can submit a PR to change
to
or
Either change could be a quick fix for my issue.
Thanks for taking your time to contribute this very useful library to the OSS community!
The text was updated successfully, but these errors were encountered: