Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage files under /ln/ folder being filtered out. #177

Open
SteveBush opened this issue Oct 12, 2022 · 1 comment
Open

Code coverage files under /ln/ folder being filtered out. #177

SteveBush opened this issue Oct 12, 2022 · 1 comment

Comments

@SteveBush
Copy link
Contributor

Either the update to the dotnet-coverage tool or an update to the preview version of the Microsoft Test SDK fixes duplicate publishing of code coverage files to the **/ln/ folder.

The test for excluding the /ln/ folder needs to be removed as code coverage files are only being published under the /ln/ folder and are currently being filtered out.

Version of test SDK:
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0-preview-20221003-04" />

old:
$coverageFiles = @(Get-ChildItem "$RepoRoot/test/*.cobertura.xml" -Recurse | Where {$_.FullName -notlike "*/In/*"  -and $_.FullName -notlike "*\In\*" })

new:
$coverageFiles = @(Get-ChildItem "$RepoRoot/test/*.cobertura.xml" -Recurse )

See #161

@AArnott
Copy link
Owner

AArnott commented Oct 12, 2022

What preview version of the test SDK are you trying this with?
The latest CI build of main for this repo shows that coverage is working. You issue description suggests that it ought to be broken.

If a preview test SDK 'fixes' the double reporting, then I suppose we can't apply the fix you propose until this template adopts that SDK. If we 'fix' this too soon, I suppose we'll be back to double-coverage collection in the template, won't we?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants