Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Typo #25

Open
chipallen2 opened this issue Sep 15, 2019 · 2 comments
Open

Possible Typo #25

chipallen2 opened this issue Sep 15, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@chipallen2
Copy link

Should this second if line be if (result.rightContent)?

    if (result.leftContent) {
      diffCount += result.leftContent.lineDiffs.filter(diff => diff.isDiff).length;
    }
    if (result.leftContent) {
      diffCount += result.rightContent.lineDiffs.filter(diff => diff.isDiff).length;
    }

@ABenassi87
Copy link
Owner

@chipallen2 Hi Chip, how are you? thank you for submitting the ticket. It looks like an issue. I will review the code and if it is an issue, I will push a fix for it. I was a little busy this year so I was not able to spend much time to work on this lib. My idea is to come back to work on this lib as soon as possible.
Regards.

@ABenassi87 ABenassi87 added the bug Something isn't working label Sep 19, 2019
@chipallen2
Copy link
Author

It seems to work fine cause it still sets the right content. So I'm guessing that it can be combined into a single if and set both left and right together.

@ABenassi87 ABenassi87 self-assigned this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants