Add Github CI/CD workflows #19
Conversation
| channels: | ||
| - accessnri | ||
| - conda-forge | ||
| - coecms |
There was a problem hiding this comment.
Out of curiosity, when do we get rid of the coecms dependency, given it's shut down now?
There was a problem hiding this comment.
There's a dependency on nchash (https://github.com/aidanheerdegen/nchash) which is deployed to the coecms conda channel. Though I'm unsure on whether the dependency is still required - see this existing issue: #11.
.github/workflows/CI.yml
Outdated
| uses: conda-incubator/setup-miniconda@a4260408e20b96e80095f42ff7f1a15b27dd94ca # v3.0.4 | ||
| with: | ||
| miniconda-version: "latest" | ||
| python-version: "3.10" # TODO: Add back in vars.PY_VERSION |
There was a problem hiding this comment.
Does this need to be changed back to vars.PY_VERSION?
There was a problem hiding this comment.
Yes, I had it commented out I think so I could test the CI without modifying the repository settings but it is now changed back in d8cae0e
.github/workflows/CI.yml
Outdated
| - name: Run conda build | ||
| shell: bash -el {0} | ||
| run: | | ||
| conda build . --no-anaconda-upload --output-folder=./build -c conda-forge -c accessnri -c coecms |
There was a problem hiding this comment.
In the channel list we have access-nri > conda-forge > coecms - does that need to be replicated here?
There was a problem hiding this comment.
Good point, I've removed the conda channels from the command (see d8cae0e) and it seems to not require them as the test runs without errors. So I've left them out to hopefully prevent any inconsistencies with the channel list in the environment file.
.github/workflows/CI.yml
Outdated
| # - name: Lint # TODO: Add back in linting | ||
| # shell: bash -l {0} | ||
| # run: pylint --extension-pkg-whitelist=netCDF4 --ignored-modules=yamanifest -E yamanifest |
There was a problem hiding this comment.
Does this need to be added back in this PR?
There was a problem hiding this comment.
I’ve just removed the pylint dependency as it was what was removed recently in um2nc-standalone repository which I used as a reference for the conda deployment CI/CD (ACCESS-NRI/um2nc-standalone#167). It would be good to set up a pre-commit hook for linting at some point (if organisational wide linting CI workflows are not set up), but I think that should be a separate PR
Add in conda-verify ignore descriptions Co-authored-by: Tommy Gatti <tommy.gatti@anu.edu.au>
- Use Github variable for python version in conda build - Remove channels from conda build - Use --exit in conda-verify so the step exits when a check fails
jo-basevi
force-pushed
the
17-Add-CD-conda-deployment-to-access-nri
branch
from
8bab942 to
d7ae55d
Compare
Yes that would be so good! |
This PR adds CI workflows for building a conda package, and runs tests, and CD workflow that will publish to
access-nriconda channel. The CI/CD workflows are basically copied from um2nc-standalone repository (https://github.com/ACCESS-NRI/um2nc-standalone). I've added a pyproject file, and versioneer for dynamic versioning so new packages will be deployed when a new git tag is pushed. I've tested it the CI workflows pass on separate repository, though theFilter filesstep did fail for me but I think that was just because the test repository I was using was private so there were permission errors.TODO:
secrets.ANACONDA_TOKENwill need to be added to this repositoryCloses #17
Closes #15