Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test when run in Intellij (#2288) #2289

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

barrybecker4
Copy link
Contributor

The path needed to be adjusted from "target" to "eclair-core/target".
Also fixed a typo in a comment.

The path needed to be adjusted from "target" to "eclair-core/target".
Also fixed a typo in a comment.
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works on my machine, @pm47 can you test on yours since you have a different setup?

@codecov-commenter
Copy link

Codecov Report

Merging #2289 (56b768e) into master (9c7ddcd) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
+ Coverage   84.32%   84.37%   +0.04%     
==========================================
  Files         194      194              
  Lines       14411    14411              
  Branches      567      567              
==========================================
+ Hits        12152    12159       +7     
+ Misses       2259     2252       -7     
Impacted Files Coverage Δ
.../src/main/scala/fr/acinq/eclair/MilliSatoshi.scala 100.00% <ø> (ø)
...in/scala/fr/acinq/eclair/channel/fsm/Channel.scala 88.39% <0.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala 91.91% <0.00%> (+1.47%) ⬆️
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala 97.56% <0.00%> (+1.62%) ⬆️
...ala/fr/acinq/eclair/balance/ChannelsListener.scala 96.55% <0.00%> (+3.44%) ⬆️

Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Welcome to the project @barrybecker4!

IIRC Intellij used to pick the current dir based on how you executed the test, usually I edited the Working Directory in the test configuration to make it work. I am guessing they did something recently because now it points to $PROJECT_DIR$.

@barrybecker4
Copy link
Contributor Author

That could be. I am using version 2022.1 of Intellij.

@pm47
Copy link
Member

pm47 commented May 30, 2022

@barrybecker4 I'm wondering, are you able to merge the PR after I acked?

@barrybecker4
Copy link
Contributor Author

@pm47 No. I do not seem to have permission.

@pm47 pm47 merged commit 45f19f6 into ACINQ:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants