Catch invoice decoding exceptions #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few requirements checked in our secp256k1 wrappers that may throw exceptions on invalid inputs. It's generally a good idea to catch exceptions when validating external, untrusted inputs.
t-bast
force-pushed
the
invoice-parsing
branch
from
e079916 to
164a45a
Compare
sstone
approved these changes
Dec 19, 2023
dpad85
added a commit
to ACINQ/phoenix
that referenced
this pull request
Jan 22, 2024
See ACINQ/lightning-kmp#567 which catches invoice decoding exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few requirements checked in our secp256k1 wrappers that may throw exceptions on invalid inputs. It's generally a good idea to catch exceptions when validating external, untrusted inputs.