Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix doesn't allow choice in BIP21 with BOLT11 in deep link #466

Closed
NicolasDorier opened this issue Nov 9, 2023 · 3 comments
Closed
Assignees
Labels
UI-android User Interface issue in the Android app

Comments

@NicolasDorier
Copy link

NicolasDorier commented Nov 9, 2023

I use Phoenix (2.0.12) on Android, when I click on the button "Pay in Wallet" with a BIP21 having a lightning=, I am not presented with a choice as I would if I just scanned the QR Code.

You can check with the following,

Here a QR Code to open the app on mobile:

image

What you see: On-Chain payment without amount prefilled.
What I am expecting: Same experience as QR Code, ie, it should ask me to pay on lightning or on-chain, and prefill the sats amount.

First question: If on-chain payment is selected by default, why the sats amount isn't even prefilled.
Second question: on-chain payment shouldn't be selected at all, instead the app should give the choice to select lightning.

Link to: btcpayserver/btcpayserver#5455

@dpad85
Copy link
Member

dpad85 commented Nov 10, 2023

Thanks for reporting this. It's a bug in the logic forwarding the bitcoin uri to the scanner, hence the amount not being filled in the payment screen, and the dialog to choose a between on-chain/off-chain being missing.

@dpad85 dpad85 self-assigned this Nov 10, 2023
@dpad85 dpad85 added the UI-android User Interface issue in the Android app label Nov 10, 2023
@NicolasDorier
Copy link
Author

NicolasDorier commented Dec 1, 2023

I look forward to see this one fixed!

Some retail merchants, rather than opening the invoice on their own device and let the customer pay as you usually see, instead they only show a QR code with the keypad app I shared in the description.

The customer scans the QR code, enter the amount, and pay on his own device. The fact the "Pay in wallet" doesn't work break the payment flow.

@dpad85 dpad85 closed this as completed in f0ae904 Dec 6, 2023
@dpad85
Copy link
Member

dpad85 commented Dec 6, 2023

This will be available in the next release. Thanks for your patience!

dpad85 added a commit that referenced this issue Dec 12, 2023
This is a temporary workaround for a regression brought in by
f0ae904 which makes the app
parse internal navigation deeplinks and fail with a visible
error message.

Also encode the full "next" URI when passing through startup.

Fixes #487
Fixes #466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI-android User Interface issue in the Android app
Projects
None yet
Development

No branches or pull requests

2 participants