meta: ingore the bin dir #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
pm47
reviewed
Nov 8, 2024
| @@ -1,6 +1,7 @@ | |||
| .gradle | |||
| build/ | |||
| .cxx | |||
| bin | |||
There was a problem hiding this comment.
How are you producing a bin directory?
There was a problem hiding this comment.
I ran ./gradlew linuxX64DistZip and the command failed, but I think also if the command will succeded the directory will be always there?
There was a problem hiding this comment.
That's strange, there is no reason why a bin directory would be created by this command. All build outputs should be under build/.
The only explanation I can think of is unzipping a jvm build, which does contain bin and lib directories.
There was a problem hiding this comment.
Ok I look now at the code and is strange yes, I will try to see if I can reproduce in a fresh env this bin stuff.
|
Closing this till I am not able to reproduce it in a fresh env |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noted this while working on #12