From 204d1744e8e104600336b276265d3b591ef05cc8 Mon Sep 17 00:00:00 2001
From: AutonomousHansen <50837800+AutonomousHansen@users.noreply.github.com>
Date: Tue, 19 Dec 2023 18:27:32 -0500
Subject: [PATCH] Adds carb logging outputs to the volumes mapped by
 docker-compose.yaml (#322)

# Description

This will cause the carb logs to be also be captured by the isaac-logs
volume.

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
---
 docker/docker-compose.yaml        | 4 ++++
 docs/source/deployment/docker.rst | 1 +
 2 files changed, 5 insertions(+)

diff --git a/docker/docker-compose.yaml b/docker/docker-compose.yaml
index b94ccba1c4..9b14e5ee3d 100644
--- a/docker/docker-compose.yaml
+++ b/docker/docker-compose.yaml
@@ -40,6 +40,9 @@ services:
       - type: volume
         source: isaac-logs
         target: ${DOCKER_USER_HOME}/.nvidia-omniverse/logs
+      - type: volume
+        source: isaac-carb-logs
+        target: ${DOCKER_ISAACSIM_PATH}/kit/logs/Kit/Isaac-Sim
       - type: volume
         source: isaac-data
         target: ${DOCKER_USER_HOME}/.local/share/ov/data
@@ -96,6 +99,7 @@ volumes:
   isaac-cache-gl:
   isaac-cache-compute:
   isaac-logs:
+  isaac-carb-logs:
   isaac-data:
   isaac-docs:
   # orbit
diff --git a/docs/source/deployment/docker.rst b/docs/source/deployment/docker.rst
index e2d4b56100..77950a7d7d 100644
--- a/docs/source/deployment/docker.rst
+++ b/docs/source/deployment/docker.rst
@@ -159,6 +159,7 @@ These are summarized below:
 * ``isaac-cache-gl``: This volume is used to store cached GLCache resources (`/root/.cache/nvidia/GLCache` in container)
 * ``isaac-cache-compute``: This volume is used to store cached compute resources (`/root/.nv/ComputeCache` in container)
 * ``isaac-logs``: This volume is used to store logs generated by Omniverse. (`/root/.nvidia-omniverse/logs` in container)
+* ``isaac-carb-logs``: This volume is used to store logs generated by carb. (`/isaac-sim/kit/logs/Kit/Isaac-Sim` in container)
 * ``isaac-data``: This volume is used to store data generated by Omniverse. (`/root/.local/share/ov/data` in container)
 * ``isaac-docs``: This volume is used to store documents generated by Omniverse. (`/root/Documents` in container)
 * ``orbit-docs``: This volume is used to store documentation of Orbit when built inside the container. (`/workspace/orbit/docs/_build` in container)