fix(users): allow changing primary body. Fixes HELP-1222 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
approved these changes
Aug 23, 2020
| expect(res.body.success).toEqual(false); | ||
| expect(res.body).not.toHaveProperty('data'); | ||
| expect(res.body).toHaveProperty('message'); | ||
| expect(res.statusCode).toEqual(200); |
There was a problem hiding this comment.
Why are you changing this test? Was it wrong from the start or is this only for the member itself?
There was a problem hiding this comment.
yeah, it wasn't supposed to work like that and was wrong from the start (it expected for the backend to return 403, while the backend should return 200 in real life)
serge1peshcoff
pushed a commit
that referenced
this pull request
Aug 24, 2020
## [1.23.2](1.23.1...1.23.2) (2020-08-24) ### Bug Fixes * **users:** allow changing primary body. Fixes HELP-1222 ([#101](#101)) ([79673e2](79673e2))
|
🎉 This PR is included in version 1.23.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now you can update your primary body not only if you have update:member permission, but also if you're trying to change your own primary body, which is how it should've worked before.
also fixed a test which was incorrect.