fix(bodies): passing transaction correctly when deleting a body #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
approved these changes
Sep 16, 2020
|
the tests won't catch this, I assume because seems like is how it works:
and when running tests, each time before each test the DB is nuked and recreated, so this won't happen. |
serge1peshcoff
pushed a commit
that referenced
this pull request
Sep 16, 2020
## [1.25.1](1.25.0...1.25.1) (2020-09-16) ### Bug Fixes * **bodies:** passing transaction correctly when deleting a body ([#120](#120)) ([f4f33d1](f4f33d1))
|
🎉 This PR is included in version 1.25.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently Model.destroy() expects a transaction as a property of the first argument, not second.
this was causing a timeout of a request when trying to delete a body, I assume this should (in theory) fix the core not responding after deleting a body.