feat(users): allow deleting users. Fixes MA-100 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1303 1309 +6
Branches 199 200 +1
=========================================
+ Hits 1303 1309 +6
Continue to review full report at Codecov.
|
WikiRik
approved these changes
Oct 15, 2020
| @@ -48,15 +48,17 @@ exports.updateUser = async (req, res) => { | |||
| }); | |||
| }; | |||
|
|
|||
| // TODO: reimplement by not deleting, but anonymizing a user. | |||
There was a problem hiding this comment.
Is this still something you would want to add in the future?
There was a problem hiding this comment.
yep, we need the ability to soft-delete a user in the future anyway. This would probably be another endpoint, as it also should be accessible by user himself
serge1peshcoff
pushed a commit
that referenced
this pull request
Oct 16, 2020
# [1.29.0](1.28.0...1.29.0) (2020-10-16) ### Features * **users:** allow deleting users. Fixes MA-100 ([#145](#145)) ([821cc08](821cc08))
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backend for https://myaegee.atlassian.net/browse/MA-100, there will be another PR for frontend