feat(general): allow listing and confirming users manually. Fixes MA-77 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1309 1321 +12
Branches 200 202 +2
=========================================
+ Hits 1309 1321 +12
Continue to review full report at Codecov.
|
WikiRik
reviewed
Oct 21, 2020
test/api/users-confirmation.test.js
Outdated
| const user = await generator.createUser({ superadmin: true }); | ||
| const token = await generator.createAccessToken({}, user); | ||
|
|
||
| await generator.createPermission({ scope: 'local', action: 'confirm', object: 'member' }); |
There was a problem hiding this comment.
Why is the scope of the permission local?
There was a problem hiding this comment.
ah yeah, accessing it with local permission doesn't make sense, as the listing is only accessed with the local one
serge1peshcoff
pushed a commit
that referenced
this pull request
Oct 21, 2020
# [1.30.0](1.29.0...1.30.0) (2020-10-21) ### Features * **general:** allow listing and confirming users manually. Fixes MA-77 ([#152](#152)) ([8b5fd16](8b5fd16))
|
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) added 2 endpoints:
b) added permissions for seeding
c) added tests