Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(body): add abbreviation #193

Merged
merged 2 commits into from
Nov 30, 2020
Merged

feat(body): add abbreviation #193

merged 2 commits into from
Nov 30, 2020

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 25, 2020

Can be used to store abbreviations for bodies like JC/CD/CEWG/ITC etc.
In the frontend I will add validation so this is not for locals.
This can also be used to generate Google groups for the body

Can be used to store abbreviations for bodies like JC/CD/CEWG/ITC etc.
In the frontend I will add validation so this is not for locals.
This can also be used to generate Google groups for the body
@WikiRik WikiRik requested a review from a team November 25, 2020 22:47
WikiRik added a commit to AEGEE/frontend that referenced this pull request Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #193 (7ba295f) into master (21933e7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1321      1322    +1     
  Branches       202       203    +1     
=========================================
+ Hits          1321      1322    +1     
Impacted Files Coverage Δ
lib/constants.js 100.00% <ø> (ø)
models/Body.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21933e7...7ba295f. Read the comment docs.

@WikiRik WikiRik merged commit 7153e5a into master Nov 30, 2020
@WikiRik WikiRik deleted the body-abbreviation branch November 30, 2020 20:03
serge1peshcoff pushed a commit that referenced this pull request Nov 30, 2020
# [1.31.0](1.30.1...1.31.0) (2020-11-30)

### Features

* **body:** add abbreviation ([#193](#193)) ([7153e5a](7153e5a))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

WikiRik added a commit to AEGEE/frontend that referenced this pull request Nov 30, 2020
* feat(body): add abbreviation

Frontend for AEGEE/core#193

* chore(body): improve v-if
@linuxbandit
Copy link
Member

good one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants