-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(login): allow people to login with gsuite_id #201
Conversation
So they can use their username, their email and their gsuite_id
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1329 1329
Branches 207 207
=========================================
Hits 1329 1329
Continue to review full report at Codecov.
|
@@ -13,7 +13,8 @@ module.exports.login = async (req, res) => { | |||
where: { | |||
[Sequelize.Op.or]: { | |||
email: { [Sequelize.Op.iLike]: username }, | |||
username: { [Sequelize.Op.iLike]: username } | |||
username: { [Sequelize.Op.iLike]: username }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a bug on frontend that only allows you to log in via email, and because of this you actually cannot login with username, fyi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, since it requires an @ in the login field. But you can still use the username when logging in to OMS JC or Wiki
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
## [1.31.2](1.31.1...1.31.2) (2020-12-14) ### Bug Fixes * **login:** allow people to login with gsuite_id ([#201](#201)) ([10229a7](10229a7))
🎉 This PR is included in version 1.31.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
So they can use their username, their email and their gsuite_id